-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBT-784 Fix-1.8.0-impala Support dbt-core 1.8.0 for dbt-impala #201
Conversation
…age structure of dbt-core.
…ule/package structure of dbt-core." This reverts commit 14b5238.
…age structure of dbt-core.
…hod to add escape character to reserved word 'skip'.
LGTM, just run the tests for all python versions. |
Hi @niteshy Tests passed on all python versions. Please find the gist here https://gist.github.com/niranjancdw/6d0f0ee196a8e90890194f90882d4780 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is there a timeline for when the pip packages will be updated to support this update? https://pypi.org/project/dbt-impala/ Keith |
Hi Keith, We are planning to do a release in the coming days, will let you know once the release is done. Regards, |
Do we have a timeline on the release? Is there anything I can do to help release it quicker? |
Hi Keith, We are planning to do the release by this week. Thanks for following up and offering help. I'll let you know once the release is done. Regards, |
Hello @ksirmons PyPi has been updated with 1.8.0 version of the adapter. Regards, |
Thank you for the notification. I did a simple upgrade
after pip upgraded dbt-impala and dbt-core I ran Found this thread: dbt-labs/dbt-core#10135 I then forced reinstalled dbt-adapters which threw some version combability issues.
Force reinstalling to those versions got my environment back working with this set of dbt pip versions:
|
Hi @ksirmons Thanks for the feedback, good to know that upgrade went fine for you. Regards, |
Describe your changes
Upgraded dbt-impala's dbt-core dependency to 1.8.0.
Internal Jira ticket number or external issue link
https://jira.cloudera.com/browse/DBT-784
Testing procedure/screenshots(if appropriate):
Test gist on all python versions
https://gist.github.com/niranjancdw/6d0f0ee196a8e90890194f90882d4780
Checklist before requesting a review