Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBT-784 Fix-1.8.0-impala Support dbt-core 1.8.0 for dbt-impala #201

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

niranjancdw
Copy link
Collaborator

@niranjancdw niranjancdw commented Jul 17, 2024

Describe your changes

Upgraded dbt-impala's dbt-core dependency to 1.8.0.

Internal Jira ticket number or external issue link

https://jira.cloudera.com/browse/DBT-784

Testing procedure/screenshots(if appropriate):

Test gist on all python versions

https://gist.github.com/niranjancdw/6d0f0ee196a8e90890194f90882d4780

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

@niteshy
Copy link
Collaborator

niteshy commented Sep 11, 2024

LGTM, just run the tests for all python versions.

@niranjancdw
Copy link
Collaborator Author

niranjancdw commented Sep 17, 2024

Copy link
Collaborator

@niteshy niteshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niranjancdw niranjancdw merged commit eb66439 into master Sep 25, 2024
@niranjancdw niranjancdw deleted the feature/upgrade-1.8.0 branch September 25, 2024 05:31
@ksirmons
Copy link

Is there a timeline for when the pip packages will be updated to support this update?

https://pypi.org/project/dbt-impala/

Keith

@niranjancdw
Copy link
Collaborator Author

Is there a timeline for when the pip packages will be updated to support this update?

https://pypi.org/project/dbt-impala/

Keith

Hi Keith,

We are planning to do a release in the coming days, will let you know once the release is done.

Regards,
Niranjan

@ksirmons
Copy link

Is there a timeline for when the pip packages will be updated to support this update?
https://pypi.org/project/dbt-impala/
Keith

Hi Keith,

We are planning to do a release in the coming days, will let you know once the release is done.

Regards, Niranjan

Do we have a timeline on the release? Is there anything I can do to help release it quicker?
Keith

@niranjancdw
Copy link
Collaborator Author

Hi Keith,

We are planning to do the release by this week. Thanks for following up and offering help. I'll let you know once the release is done.

Regards,
Niranjan

@niranjancdw
Copy link
Collaborator Author

Hello @ksirmons

PyPi has been updated with 1.8.0 version of the adapter.

Regards,
Niranjan

@ksirmons
Copy link

ksirmons commented Nov 14, 2024

Hello @ksirmons

PyPi has been updated with 1.8.0 version of the adapter.

Regards, Niranjan

Thank you for the notification.
Upgraded the package today and after some errors it all appears to be working well.

I did a simple upgrade

pip install dbt-impala --upgrade

after pip upgraded dbt-impala and dbt-core I ran dbt --version and received an error message
dbt No module named 'dbt.adapters.factory'

Found this thread: dbt-labs/dbt-core#10135

I then forced reinstalled dbt-adapters
pip install --force-reinstall dbt-adapters

which threw some version combability issues.

pip install --force-reinstall dbt-adapters==1.7.0
pip install --force-reinstall dbt-common==1.10.0

Force reinstalling to those versions got my environment back working with this set of dbt pip versions:

dbt-adapters==1.7.0
dbt-common==1.10.0
dbt-core==1.8.8
dbt-extractor==0.5.1
dbt-impala==1.8.0

@niranjancdw
Copy link
Collaborator Author

Hi @ksirmons

Thanks for the feedback, good to know that upgrade went fine for you.

Regards,
Niranjan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants